bump dind image to 18.09.2 #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minrk users can still run as uid0 during the docker build itself, so we should still deploy this. |
|
Ah, I think I'm saying the same thing you're saying! |
|
Yup, I could have been clearer. For "users" I meant jupyterhub user pods ("launches" I guess in Binder terms), so only builds were affected. This was already deployed to mybinder.org: jupyterhub/mybinder.org-deploy#899 this PR only changes the default for binderhub. |
|
Awesome, thanks @minrk |
yuvipanda
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for CVE-2019-5736
users don't appear to be affected since we run them as uid 1000 and the vulnerability appears to require pods to run as uid 0