Docs Improvement | Setup BinderHub #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update --version argument in helm install command to the specific 0.2.0-3b53fce helm chart * Explain that the commit hash is all that needs to change to install a different helm chart version
Reword step 3.4 Install BinderHub to explain that the commit hash given is a working example and in practice the user should find the commit hash for the most recent version.
In Step 3.5, clarify that the commit hash given to the helm upgrade command should be the same as that given in step 3.4 to the helm install command on first deployment of a BinderHub. However, it does not have to be the same if the BinderHub is being updated.
* CircleCI build_docs failure * Message: Warning, treated as error: /home/circleci/project/doc/setup-binderhub.rst:258:Literal block ends without a blank line; unexpected unindent. * Add newline at line 258
|
Can someone advise on the Travis failure please? |
|
This looks good to me ;D I think the travis test failure is just flaking out for some reason unrelated to this PR. I restarted it. |
|
(restarted travis) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some changes to the Set up BinderHub page of the Zero-to-BinderHub documentation and partially addresses issue #803
Changes include:
helm installcommand via--versionflaghelm upgradecommand via--versionflag should match the one used in step 3.4