Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Manually list BinderHub dependencies in docs requirements #879

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

betatim
Copy link
Member

@betatim betatim commented Jun 17, 2019

Our docs build broken when pycurl was added as a dependency. It has some non Python package requirements that aren't fulfilled on RTD. This PR copies the requirements to the docs requirements manually. I think we change our dependencies rarely enough that we can get away having to synnc them manually.

@betatim betatim requested a review from willingc June 17, 2019 06:13
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make a small modification to the comment. Otherwise, this is fine.

We should at some point switch RTD to using the v2 build API for building docs.

doc/doc-requirements.txt Outdated Show resolved Hide resolved
@betatim betatim changed the title [MRG] Manually list BinderHub dependencies inn docs requirements [MRG] Manually list BinderHub dependencies in docs requirements Jun 17, 2019
Co-Authored-By: Carol Willing <carolcode@willingconsulting.com>
@betatim betatim merged commit 580a8bc into jupyterhub:master Jun 17, 2019
@betatim betatim deleted the fix-docs-build branch June 17, 2019 19:21
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants