Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update documentation for "GitHub API limit" #905

Merged
merged 1 commit into from
Jul 26, 2019
Merged

update documentation for "GitHub API limit" #905

merged 1 commit into from
Jul 26, 2019

Conversation

bitnik
Copy link
Collaborator

@bitnik bitnik commented Jul 26, 2019

This is a small change about how GitHubRepoProvider.access_token is used. It is not loaded into a env variable anymore (probably since passthrough config is introduced) but passed directly to GitHubRepoProvider:

binderhub/helm-chart/binderhub/templates/secret.yaml

Lines 11 to 13 in 137ec19

{{- if $cfg.GitHubRepoProvider }}
{{- $_ := set $values.config "GitHubRepoProvider" (pick $cfg.GitHubRepoProvider "client_id" "client_secret" "access_token")}}
{{- end }}

@betatim betatim merged commit 3ff6625 into jupyterhub:master Jul 26, 2019
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 26, 2019
[binderhub] Automatic update for commit 9c3045e
3f2b313 
jupyterhub/binderhub#905
@henchbot henchbot mentioned this pull request Jul 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bitnik @betatim @choldgraf