Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute URL for social image #907

Merged
merged 2 commits into from
Jul 28, 2019
Merged

absolute URL for social image #907

merged 2 commits into from
Jul 28, 2019

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Jul 28, 2019

From looking at the twitter card validator it seems like we are correctly pulling some information from the binder link, but it looks from this SO post that the open graph images will only work with absolute URLs.

So let's try coding an absolute URL for mybinder.org in there

https://stackoverflow.com/questions/9858577/open-graph-can-resolve-relative-url

In the future perhaps we can expose a template variable like base_url though I'm not sure how to actually set that variable

@choldgraf
Copy link
Member Author

I'm gonna merge and deploy once the tests pass because this is pretty minor + doesn't work now anyway :-)

@choldgraf
Copy link
Member Author

merging since first tests passed and the next commit just added a couple meta tags

@choldgraf choldgraf merged commit 306d779 into master Jul 28, 2019
@choldgraf choldgraf deleted the choldgraf-patch-2 branch July 28, 2019 15:04
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 28, 2019
@betatim
Copy link
Member

betatim commented Jul 28, 2019

To include the host checkout https://www.tornadoweb.org/en/stable/web.html#tornado.web.RequestHandler.static_url though we probably want to use

https://github.com/jupyterhub/binderhub/blob/master/binderhub/app.py#L148-L158

as the "base" instead of the host on which BinderHub is actually running. In the case of our federation it would mean you'd get different URLs depending on which cluster you get sent to. I think.

@choldgraf choldgraf added the maintenance Under the hood improvements and fixes label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants