New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add hydroshare as a repo provider #967
Changes from all commits
fb05c64
5976f16
1d37ef2
57661ee
e034264
a561af9
8867a95
44b5571
f88396c
1954009
9d38045
69bb809
3bfee95
7cfad48
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,6 +55,7 @@ <h4 id="form-header" class='row'>Build and launch a repository</h4> | |
<li class="dropdown-item" value="git"><a href="#">Git repository</a></li> | ||
<li class="dropdown-item" value="zenodo"><a href="#">Zenodo DOI</a></li> | ||
<li class="dropdown-item" value="figshare"><a href="#">Figshare DOI</a></li> | ||
<li class="dropdown-item" value="hydroshare"><a href="#">Hydroshare resource</a></li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am unsure about the wording here, because for Zenodo and Fishare, we also support plain Zenodo URLs (they are just patched through), and it seems the Hydroshare support in repo2docker also supports DOIs... @betatim What wording should BinderHub use here? Favour "DOI" or "resource" (or "record"). I'd tend towards only talking about DOIs externally, but not failing when direct resource URLs are provided. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I used resource because it is a HydroShare term. I'm fine highlighting the DOI, but I do think it'd be good to point to a resource id as well, because resources don't have a functional DOI until they publish the resource. Let me know what you'd like, and I can update it in this PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if there's a provider-specific wording, we can just use that since a user familiar with it will be expecting that word (as long as it's not too long or complex) |
||
<li class="dropdown-item" value="dataverse"><a href="#">Dataverse DOI</a></li> | ||
</ul> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_resolved_spec and get_resolved_ref_url were two methods that I've implemented since the original review. With what I gleaned from the documentation, resolving to get_repo_url() made sense for HydroShare. If this is incorrect, I'll need suggestions to guide a different implementation.