Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bumpversion #37

Merged
merged 2 commits into from
Oct 2, 2015
Merged

use bumpversion #37

merged 2 commits into from
Oct 2, 2015

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 2, 2015

and set current to 0.5.0-dev

minrk added a commit that referenced this pull request Oct 2, 2015
@minrk minrk merged commit d6ee158 into jupyterhub:master Oct 2, 2015
@minrk minrk deleted the bump branch October 2, 2015 12:24
@rgbkrk
Copy link
Member

rgbkrk commented Oct 12, 2015

What's the opposition to npm version followed by npm publish. The argument to npm version can be major, minor, or patch - it bumps the version and tags for you.

@minrk
Copy link
Member Author

minrk commented Oct 12, 2015

@rgbkrk Not really, though I do require that tags are X.Y.Z, not vX.Y.Z. Can npm version be told how to format tags?

@rgbkrk
Copy link
Member

rgbkrk commented Oct 12, 2015

If using npm dist-tag directly you can, but they ominously say not to create tags beginning with v:

Tags that can be interpreted as valid semver ranges will be rejected. For example, v1.4 cannot be used as a tag, because it is interpreted by semver as >=1.4.0 <1.5.0. See npm/npm#6082.

The simplest way to avoid semver problems with tags is to use tags that do not begin with a number or the letter v.

@minrk
Copy link
Member Author

minrk commented Oct 12, 2015

dist-tag doesn't write git tags, though, does it? npm version seems to unconditionally make tags with v. bumpversion, as is the Python way, lets you actually tell it what to do. npm, as is the Javascript way, seems to unconditionally do what I don't want it to, with no ability to tell it to do the right thing.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 12, 2015

Generally though, you can just override npm version:

"scripts": {
  "preversion": "npm test",
  "version": "bumpversion <args>",
  "postversion": "git push && git push --tags"
}

@minrk
Copy link
Member Author

minrk commented Oct 12, 2015

Ah, sure, in which case npm version offers nothing at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants