Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dconf user config to fix terminal font display #85

Closed
wants to merge 1 commit into from

Conversation

manics
Copy link
Member

@manics manics commented Feb 5, 2024

I've no idea why but it's been like this for ages:
image

After this fix
image

Copy link

github-actions bot commented Feb 5, 2024

Binder 👈 Launch a binder notebook on this branch for commit 01a4737

I will automatically update this comment whenever this PR is modified

@manics manics changed the title Add dconf to fix terminal font display Add dconf user config to fix terminal font display Feb 5, 2024
# To recreate this file run:
# dconf write /org/gnome/terminal/legacy/profiles:/:b1dcc9dd-5262-4d8d-a863-c897e6d979b9/font "'Liberation Mono 12'"
# dconf write /org/gnome/terminal/legacy/profiles:/:b1dcc9dd-5262-4d8d-a863-c897e6d979b9/use-system-font false
COPY --chown=$NB_UID:$NB_GID dconf/user /home/$NB_USER/.config/dconf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be put where it won't be replaced by a user home directory mount instead - under etc or similar?

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate getting a better separation of things for the Dockerfile from whats for the python package etc. Not sure on what i propose, but putting a binary blob file in a dconf/ folder will make this repo a bit harder to understand by glancing on files in it.

(This isn't a comment that needs to be addressed)

@yuvipanda
Copy link
Contributor

Testing #86 as an alternative fix

@yuvipanda
Copy link
Contributor

#86 fixes it!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants