Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TigerVNC detection for non-apt installations #96

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Feb 29, 2024

I think we checked the case sensitive TigerVNC string which works if TigerVNC was installed via apt, but may not work when installed in another way. On the other hand, at those times, checking for the case insensitive string would work then. So, this PR makes the check case insensitive.

Thank you @goekce for your thorough issue report!!

Copy link

Binder 👈 Launch a binder notebook on this branch for commit 2896efa

I will automatically update this comment whenever this PR is modified

@consideRatio consideRatio added the bug Something isn't working label Feb 29, 2024
@consideRatio
Copy link
Member Author

Does this look right to you @goekce?

Copy link
Contributor

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works for the issue reporter!

@goekce
Copy link

goekce commented Mar 1, 2024

I could not test on an installation due to lack of capacity right now.

I believe the command line arguments to tigervnc and turbovnc may be different. In #69 I had mentioned that -xstartup is not accepted by tigervnc:

if not os.path.exists(os.path.expanduser('~/.vnc/xstartup')):
vnc_args.extend(['-xstartup', os.path.join(HERE, 'share/xstartup')])

I searched for but could neither find any reference to xstartup in the source code of tigervnc nor in the documentation:

https://github.com/search?q=repo%3ATigerVNC%2Ftigervnc%20xstartup&type=code

Further arguments must also be tested:

vnc_command = shlex.join(
vnc_args
+ [
'-verbose',
'-geometry',
'1680x1050',
'-SecurityTypes',
'None',
'-fg',
]

This is the reason why I think in the long term the arguments should be configurable by the user.

@consideRatio
Copy link
Member Author

consideRatio commented Mar 1, 2024

Thank you @goekce, I opened #98 to represent that - let's go for a merge on this bug for now. I'll try to get it all the way so there is actual turbovnc support as we've commited to have.

@consideRatio
Copy link
Member Author

Thank you for reviewing @yuvipanda and @goekce!!

@consideRatio consideRatio merged commit 3df5407 into jupyterhub:main Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TigerVNC check does not work for new versions of TigerVNC
3 participants