Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite /auth-sign-in redirect. #108

Closed
wants to merge 3 commits into from
Closed

Rewrite /auth-sign-in redirect. #108

wants to merge 3 commits into from

Conversation

ryanlovett
Copy link
Collaborator

This depends on jupyterhub/jupyter-server-proxy#300 and is intended to fix #97.

It also removes the version environment variable and detection function. If/when this is merged we can bump the version dependency.

@garyburgmann
Copy link

garyburgmann commented Nov 9, 2021

@ryanlovett I can confirm that this solution is working for us (we are simply mirroring your branches):

https://gitlab.com/ecocommons-australia/ecocommons-platform/analysis-playground-notebooks/-/blob/fa33d9ff7714a05449e70c1a4c13a5ee1743374b/r-base/Dockerfile#L66

image

Thank you!

@ryanlovett
Copy link
Collaborator Author

@garyburgmann Thanks for checking, it works on mybinder and a local hub too. Its the worst-case solution, though it might not be how things are solved in the end.

@ryanlovett
Copy link
Collaborator Author

I'm closing this in favor of another that is based on the latest changes to jupyter-server-proxy.

@ryanlovett ryanlovett closed this Nov 30, 2021
@garyburgmann
Copy link

@ryanlovett are you able to elaborate on the other other preferred solution that was used?

@ryanlovett
Copy link
Collaborator Author

@garyburgmann Yes, please see #110. I guess I should have just folded my newer branch's changes into this one.

@garyburgmann
Copy link

thanks for that @ryanlovett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Forwarded-Proto header causes 404 with rstudio server 1.4
2 participants