Skip to content

Commit

Permalink
Declare tornado and traitlets as dependencies explicitly
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Feb 21, 2024
1 parent 0b6669f commit 26b59d8
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 13 additions & 1 deletion .github/workflows/test.yaml
Expand Up @@ -76,6 +76,7 @@ jobs:
os: [ubuntu-22.04, windows-2022]
python-version: ["3.8", "3.11"]
pip-extras: ["lab", "classic"]
pip-install-constraints: [""]
exclude:
# windows should work for all test variations, but a limited selection
# is run to avoid doubling the amount of test runs
Expand All @@ -86,6 +87,17 @@ jobs:
python-version: "3.8"
pip-extras: lab

# this test is manually updated to reflect the lower bounds of
# versions from dependencies
- os: ubuntu-22.04
python-version: "3.8"
pip-extras: classic
pip-install-constraints: >-
jupyter-server==1.0
simpervisor==1.0
tornado==5.0
traitlets==4.2.1
steps:
- uses: actions/checkout@v4

Expand All @@ -108,7 +120,7 @@ jobs:
#
# Pytest options are set in `pyproject.toml`.
run: |
pip install -vv $(ls ./dist/*.whl)\[acceptance,${{ matrix.pip-extras }}\]
pip install -vv $(ls ./dist/*.whl)\[acceptance,${{ matrix.pip-extras }}\] ${{ matrix.pip-install-constraints }}
- name: List Python packages
run: |
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Expand Up @@ -50,6 +50,8 @@ dependencies = [
"importlib_metadata >=4.8.3 ; python_version<\"3.10\"",
"jupyter-server >=1.0",
"simpervisor >=1.0",
"tornado >=5.0",
"traitlets >= 4.2.1",
]

[project.optional-dependencies]
Expand Down

0 comments on commit 26b59d8

Please sign in to comment.