Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures in main branch #449

Closed
consideRatio opened this issue Feb 19, 2024 · 4 comments · Fixed by #451
Closed

Test failures in main branch #449

consideRatio opened this issue Feb 19, 2024 · 4 comments · Fixed by #451

Comments

@consideRatio
Copy link
Member

consideRatio commented Feb 19, 2024

There are acceptance test failures in main branch (example here).

A key part of the failure is:

==============================================================================
Acceptance.Notebook :: Server Proxies in Notebook                             
==============================================================================
Notebook Loads                                                        | PASS |
------------------------------------------------------------------------------
Launch Browser Tab                                                    | FAIL |
Element with locator 'xpath://div[contains(@class, "jp-FileBrowser-toolbar")]//*[contains(text(), "New")]' not found.
------------------------------------------------------------------------------
Launch Another Browser Tab                                            | FAIL |
Element with locator 'xpath://div[contains(@class, "jp-FileBrowser-toolbar")]//*[contains(text(), "New")]' not found.

They seem to show up due to this part:

*** Variables ***
${XP_NEW_MENU} xpath://div[contains(@class, "jp-FileBrowser-toolbar")]//*[contains(text(), "New")]
${XP_OPEN_COMMAND} xpath://li[@data-command = "server-proxy:open"]

And specifically with notebook==7.1.1 but not with notebook==7.0.8.

I understand those expressions to be selecting a specific HTML element, but I think if it worked once it should work later as I see no difference in the HTML looking at it with old/new versions.

image
image

@consideRatio
Copy link
Member Author

consideRatio commented Feb 20, 2024

@bollwyvl I'm stumped, it sais Element with locator 'xpath://div[contains(@class, "jp-FileBrowser-toolbar")]//*[contains(text(), "New")]' not found. when using notebook==7.1.* but not when using notebook==7.0.*.

I tried opening a chrome inspector console and doing $x(......) stuff in order to see if I could reproduce the difference, but I ended up getting an empty [] response no matter if I've used notebook==7.1.* or 7.0.*. I don't understand xpath expressions yet or if this debugging strategy was reasonable =/

Do you have ideas on debugging / resolving this issue?

@bollwyvl
Copy link
Collaborator

yes, 4.1 and 7.1 created breaking changes in the DOM.

@consideRatio
Copy link
Member Author

@bollwyvl ah thanks, I'm making progress now!

@manics
Copy link
Member

manics commented Feb 20, 2024

I think this could be a good case for using dependabot to pin some dependencies for CI testing. Keep the dev dependencies unrestricted in pyproject.toml, but use a separate dev-ci-requirements.txt file for CI only and let dependabot tell us when there's a UI change in lab or notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants