Ensure no blank Sec-Websocket-Protocol headers and warn if websocket subprotocol edge case occur
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
test-subprotocols
branch
2 times, most recently
from
a61619a
to
4d9cd5b
Compare
|
@consideRatio I merged |
consideRatio
changed the title
Sec-Websocket-Protocol headers and warn about other websocket issues
consideRatio
changed the title
Sec-Websocket-Protocol headers and warn about other websocket issuesSec-Websocket-Protocol headers and warn about another websocket issue
consideRatio
changed the title
Sec-Websocket-Protocol headers and warn about another websocket issueSec-Websocket-Protocol headers and warn if websocket subprotocol edge case occur
minrk
approved these changes
Feb 23, 2024
consideRatio
force-pushed
the
test-subprotocols
branch
from
51759fc
to
eda6136
Compare
|
Rebased to be put on top of #457 not bundled with this PR but with commits now in main. |
|
I was able to confirm this fixed our issue on the NASA side (FYI @zoghbi-a)! Thanks so much @consideRatio for patching this bug and @benz0li for helping with the investigation! Glad to see a powerful example of open source community coming together to fix this issue :) We look forward to the 4.1.1 release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we don't pass a blank
Sec-Websocket-Protocolheader (Sending a blank header is incorrect) when we proxy a websocket. This fixes #442, fixes #445, is assumed to fix #332, and closes #448.This project currently proxies websockets by first accepting an incomming websocket connection were a subprotocol is established, and then opening a websocket connection to a server to proxy to. This is a problem and can lead to bugs that we now warn about. This PR adds tests to document our current problematic handling.
Thank you @duytnguyendtn, @zoghbi-a, and @benz0li for working this - this is building a lot on their investigation and conclusions, which were critical as I didn't understand much about this before.