Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text wrap in documentation tables. #3097

Closed
Zsailer opened this issue Jun 19, 2020 · 8 comments
Closed

Text wrap in documentation tables. #3097

Zsailer opened this issue Jun 19, 2020 · 8 comments

Comments

@Zsailer
Copy link
Member

Zsailer commented Jun 19, 2020

I caught this in the events schema page:
https://jupyterhub.readthedocs.io/en/stable/events/server-actions.html

It looks like the new sphinx theme doesn't wrap text in table cells, leading to ultra-wide tables that don't fit on the page. Ideally, we could tables to the width of the page and wrap text as needed. This issue likely belongs in pydata_sphinx_theme, but opening this here to track our own pages.

@choldgraf, do you know how to fix this? I tried to do some digging quickly but didn't make much progress.

@welcome
Copy link

welcome bot commented Jun 19, 2020

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Zsailer
Copy link
Member Author

Zsailer commented Jun 19, 2020

^ This is awesome. I love it.

Also, a bit surprised this is my first issue on this repo. 😆

@choldgraf
Copy link
Member

whoahhhh lol that's a big page...

hmmm, I am not quite sure. Can you try re-building the docs on readthedocs first to make sure this isn't a bug that's been squashed in the theme? I don't have admin rights to this repo on RTD

@choldgraf
Copy link
Member

also ya @GeorgianaElena your bot is awesome

@Zsailer
Copy link
Member Author

Zsailer commented Jun 19, 2020

I also don't have admin rights on RTD.

But, I did build these docs locally, and I see the same issue. For reference, I had to add custom CSS previously to handle text wrapping in large tables (see this jupyter/notebook telemetry docs PR).

We'll probably need to add something similar to override the CSS here.

@choldgraf
Copy link
Member

can you also open an issue in the pydata-sphinx-theme?

@Zsailer
Copy link
Member Author

Zsailer commented Jun 19, 2020

Done! 🚀

pydata/pydata-sphinx-theme#205

@manics
Copy link
Member

manics commented May 22, 2022

It looks like this was fixed at some point, https://jupyterhub.readthedocs.io/en/stable/events/server-actions.html looks fine to me:
image

(though pydata/pydata-sphinx-theme#205 is still open)

@manics manics closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants