Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin ui prevents editing 2-character usernames #4015

Closed
dcnadler opened this issue Aug 15, 2022 · 4 comments · Fixed by #4016
Closed

admin ui prevents editing 2-character usernames #4015

dcnadler opened this issue Aug 15, 2022 · 4 comments · Fixed by #4016

Comments

@dcnadler
Copy link

Proposed change

Change the min length of username from 3 to 2: https://github.com/jupyterhub/jupyterhub/blob/main/jsx/src/components/EditUser/EditUser.jsx#L130

Our organization uses last name as usernames and people with two-letter last names cannot be added through the front-end.

Alternative options

None

Who would use this feature?

Those who want 2-letter usernames

@welcome
Copy link

welcome bot commented Aug 15, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@minrk
Copy link
Member

minrk commented Aug 16, 2022

Just to be clear, did you only encounter this issue editing users via the admin UI? JupyterHub doesn't prohibit 2-character usernames in general.

@minrk
Copy link
Member

minrk commented Aug 16, 2022

The client-side validation should all be removed, I think #4016 finishes that.

@dcnadler
Copy link
Author

Just to be clear, did you only encounter this issue editing users via the admin UI? JupyterHub doesn't prohibit 2-character usernames in general.

Correct. We can add users with 2-letter usernames fine with jupyterhub_config.py, it was just the front-end that prevented it.

Thanks for the fix!

@minrk minrk changed the title Change username length requirment admin ui prevents 2-character usernames Aug 17, 2022
@minrk minrk changed the title admin ui prevents 2-character usernames admin ui prevents editing 2-character usernames Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants