Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar in admin page has wrong links #4622

Open
elferherrera opened this issue Oct 31, 2023 · 11 comments
Open

Navbar in admin page has wrong links #4622

elferherrera opened this issue Oct 31, 2023 · 11 comments
Labels

Comments

@elferherrera
Copy link

Bug description

When entering the admin page, the navbar has the wrong links and the Jupyterhub logo is missing

image

The links for home, token and admin are also broken. They are missing the /hub part in the url

How to reproduce

I'm using the helm chart 3.1.0 with jupyterhub image jupyterhub/k8s-hub:3.1.0

@welcome
Copy link

welcome bot commented Oct 31, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

I'm looking at an installation of the jupyterhub chart 3.1.0 and it presents itself correctly there. Inspecting the HTML I see this:

<img src="/hub/logo" alt="JupyterHub logo" class="jpy-logo" title="Home">

The full URL looks like https://my-hub.org/hub/logo for me.

What is your full URL?

@elferherrera
Copy link
Author

I see this in the tree
image

image

@elferherrera
Copy link
Author

is there an admin configuration that I might be missing?

@consideRatio
Copy link
Member

consideRatio commented Oct 31, 2023

@elferherrera is there an configuration you have made to influence this is what I'm thinking mostly of. What configuration are you passing when installing the helm chart that overrides the default values?

Anything related to base url for example, such as hub.config.JupyterHub.base_url (don't use this) or hub.baseUrl (this should be fine to use).

{% block logo %}
<span id="jupyterhub-logo" class="pull-left">
<a href="{{logo_url or base_url}}"><img src='{{base_url}}logo' alt='JupyterHub logo' class='jpy-logo' title='Home'/></a>
</span>
{% endblock %}
{% if user %}

image

@elferherrera
Copy link
Author

No extra configuration on my side. The only configuration for hub is the GenericOAuthenticator definition

@consideRatio
Copy link
Member

Is the hub exposed directly so you can see it when visiting https://<your domain>/hub/home?

@elferherrera
Copy link
Author

Yeap. That's how it is exposed. It is weird that as soon as I click on the admin page, the links change. I was checking the templates and all the pages use the same nav template. So I dont know why it would change

@consideRatio
Copy link
Member

Yeap. That's how it is exposed. It is weird that as soon as I click on the admin page, the links change. I was checking the templates and all the pages use the same nav template. So I dont know why it would change

Did the links work, and then no longer work in the admin panel?

@elferherrera
Copy link
Author

since I did the updated to the latest chart the link stopped working

@marcelovilla
Copy link

I can reproduce this locally using JupyterHub 4.0.2—check the lower left corner where the URLs appear:

Screen.Recording.2024-03-25.at.4.57.58.PM.mov

While the links are correctly redirected in JupyterHub, I am not sure this behavior is intended. I found out about this by deploying JupyterHub in k8s and getting 404: Not found errors when trying to access any of the items in the navbar after visiting the Admin dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants