Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate redundant singleuser_ prefix on config #101

Closed
minrk opened this issue Nov 24, 2017 · 2 comments · Fixed by #183
Closed

Deprecate redundant singleuser_ prefix on config #101

minrk opened this issue Nov 24, 2017 · 2 comments · Fixed by #183

Comments

@minrk
Copy link
Member

minrk commented Nov 24, 2017

when configuring the Spawner, several traits have a singleuser_ prefix. This is mostly redundant with the fact that a Spawner is all about configuring a singleuser server. Most (probably all) of these should be deprecated in favor of the same name without singleuser_. The singleuser_ names can be kept as a deprecated alias from config to avoid breaking existing config.

@minrk
Copy link
Member Author

minrk commented Nov 24, 2017

The same probably goes for the few user_ traits, where user is a synonym for singleuser.

@yuvipanda
Copy link
Collaborator

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants