Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to handle imagePullSecrets for private docker registries #23

Closed
Analect opened this issue Feb 17, 2017 · 2 comments
Closed

Comments

@Analect
Copy link
Contributor

Analect commented Feb 17, 2017

@yuvipanda
I was wondering if the kubespawner could be extended to handle a new parameter imagePullSecrets.

My use-case is that I'm using a private registry to contain images. I'm running a cluster on GKE, which enables automatic authentication against the Google Cloud Registry (gcr.io), but not private ones.

As per these docs, there are a couple of work-arounds. Specifically at the section Creating a Secret with a Docker Config, it shows how a secret for the private registry can be created.

Then, in order for an image contained in a kubernetes manifest file to get pulled (in our case, the image used to underpin a notebook server), then additionally the imagePullSecrets parameter needs to be supplied.

Here is an example of what I mean.

In the meantime, if I wanted to hard-code in a secret name, could I just add in that parameter here?

Thanks.

@yuvipanda
Copy link
Collaborator

Merged your patch now! Thank you very much!

@Analect
Copy link
Contributor Author

Analect commented Feb 19, 2017

@yuvipanda ... in case you didn't notice, just a heads-up .. the patch that @shraykay added here ended up not getting merged, since I think it was missing the new parameter in test/test_objects.py and failed in the build pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants