Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option: use_tls #216

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

loic-vial
Copy link

@loic-vial loic-vial commented Mar 14, 2023

Hello !

Thank you for the work done on this plugin ! I am currently using it for accessing JupyterHub in our data science team at my company, but I needed to add an option "use_tls" and set it to False to actually make it work. That is because we need to connect to a LDAP server that needs this configuration.

For information, such option exists in the LDAP connector used by Airflow, another tool that we are also using. There is distincts "USE_SSL" and "USE_TLS" options for addressing our use case, so I just applied the same logic.

I hope that my PR is correct, I simply added the option "use_tls" and a small test for testing the option. I also needed to update the black pre-commit hook because it didn't work on my computer.

Obviously, the default value of this option does not change anything on the current behavior.

Thank you !

@welcome
Copy link

welcome bot commented Mar 14, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant