Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix documentation for LTI1.1 #104

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

martinclaus
Copy link
Collaborator

When using ltiauthenticator.LTIAuthenticator as the authenticator class, the respective section in the config.yml must be named LTIAuthenticator for the traitlet system to work.

Alternatively, one could instead change to

JupyterHub:
    authenticator_class: ltiauthenticator.lti11.auth.LTI11Authenticator

in the config.yml which would be analogous to the LTI1.3 configuration.

@welcome
Copy link

welcome bot commented Jun 9, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jgwerner jgwerner self-requested a review June 9, 2022 16:24
@jgwerner
Copy link
Collaborator

jgwerner commented Jun 9, 2022

Hi @martinclaus ! Thank you so much for picking up on this documentation update. We will go ahead and merge this to avoid future headaches when using the config.yml.

@jgwerner jgwerner merged commit 2436daa into jupyterhub:main Jun 9, 2022
@welcome
Copy link

welcome bot commented Jun 9, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@martinclaus martinclaus changed the title Fix documentation for LTI1.1 docs: Fix documentation for LTI1.1 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants