maint: Ditch dependency to OAuthenticator #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinclaus
changed the title
consideRatio
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
I didn't review the test code changes, but this looks great from what I can tell.
If you have verified this to work, 👍 for merging without further ado!
I appreciate that you have included docstrings for small functions as well, for example compare value in cookie with redirect url param, I love it!!
Oh, merge conflicts to resolve, but seems trivial.
|
I successfully tested this PR on a local deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155