Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readiness probe to ensure deployment is ready before testing #181

Closed
minrk opened this issue Nov 30, 2017 · 1 comment
Closed

add readiness probe to ensure deployment is ready before testing #181

minrk opened this issue Nov 30, 2017 · 1 comment

Comments

@minrk
Copy link
Member

minrk commented Nov 30, 2017

We should add a readiness probe that verifies that the deployment is responding to requests on the public URLs (i.e. that the servers are up and kube-lego has done its business). This ought to prevent failed deploys on Travis that occur when the tests start faster than the deployment becomes ready.

I put a band-aid on #180 in the mean-time, but that should go away when we get a proper check.

@choldgraf
Copy link
Member

I believe we now have this in the deploy travis script, so closing this! https://github.com/jupyterhub/mybinder.org-deploy/blob/master/.travis.yml#L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants