Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release needed for JupyterHub 2 and 3 compatibility #214

Closed
consideRatio opened this issue Aug 25, 2022 · 2 comments · Fixed by #218
Closed

Release needed for JupyterHub 2 and 3 compatibility #214

consideRatio opened this issue Aug 25, 2022 · 2 comments · Fixed by #218

Comments

@consideRatio
Copy link
Member

consideRatio commented Aug 25, 2022

#160 was merged just after 1.0.5 was released, and we need a release including it for functionality with JupyterHub 2 and 3. The JupyterHub Helm chart in https://github.com/jupyterhub/zero-to-jupyterhub-k8s will include JupyterHub 3 so users of nativeauthenticator can't upgrade to it unless a patch is released.

Generating a changelog using github-activity I saw the following PRs merged since 1.0.5. Is any change here a breaking change that merits a 2.0.0 release? Otherwise, it should be a 1.1.0 release as it includes enhancements etc rather than just documentation/bugfixes.

1.0.5...master@{2022-08-25}

(full changelog)

Enhancements made

  • Ask for new passwords twice, ask for current password on change #180 (@lambdaTotoro)

Bugs fixed

Maintenance and upkeep improvements

Documentation improvements

Continuous integration improvements

@consideRatio
Copy link
Member Author

consideRatio commented Sep 9, 2022

@lambdaTotoro now JupyterHub 3.0.0 is out and z2jh 2.0.0 could be released today, but nativeauthenticator will be broken with that version bump of JupyterHub from JupyterHub 1 to JupyterHub 3 made in the z2jh distribution of JupyterHub.

Is it okay if I'll go for a release of nativeauthenticator 1.1.0 in its current state?

@lambdaTotoro
Copy link
Collaborator

Yes, go ahead. I would have liked to incorporate a few things still, but I didn't get to them in time and this is more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants