Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate with https://haveibeenpwned.com/ #71

Open
Carreau opened this issue Mar 15, 2019 · 3 comments · May be fixed by #186
Open

integrate with https://haveibeenpwned.com/ #71

Carreau opened this issue Mar 15, 2019 · 3 comments · May be fixed by #186
Labels
enhancement New feature or request
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented Mar 15, 2019

See also https://www.troyhunt.com/ive-just-launched-pwned-passwords-version-2/

It provide at least js API that are privacy protecting and can indicate if password is in already leaked password.

That can (and should?) also be triggerd on each login, instead of only when password are set, in case the pwd is leaked after bing set.

@leportella leportella added the enhancement New feature or request label Aug 8, 2019
@lambdaTotoro
Copy link
Collaborator

I still think is a good idea, but what form do you think this should take, @Carreau?
Alert when someone's email is in a breach? Someone's password? Both?

@Carreau
Copy link
Member Author

Carreau commented May 6, 2021 via email

@lambdaTotoro
Copy link
Collaborator

I think I'd like to get this into the 1.1 release. We already have a function that checks if a password is too common. Currently that just looks up a local txt file with common passwords, I could easily see that it tries to talk to the API first and only uses the txt file as a fallback.

We probably want to enforce entirely fresh passwords that have not been included in any leak, and not just fewer than n times. We might need to be more specific with out error messages though.

@lambdaTotoro lambdaTotoro added this to the Version 1.1 milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants