Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require users to confirm password in signup screen #73

Closed
yuvipanda opened this issue Apr 17, 2019 · 7 comments · Fixed by #180
Closed

Require users to confirm password in signup screen #73

yuvipanda opened this issue Apr 17, 2019 · 7 comments · Fixed by #180
Labels
good first issue Good for newcomers
Milestone

Comments

@yuvipanda
Copy link
Contributor

We should have users type their password in twice during signup to make sure they are not making typos. Currently it's easy to make a typo and then be unable to log in.

@leportella
Copy link
Collaborator

The text we used to base other password strength characteristcs pointed out that being able to see the password is better then writing it twice, since allows you to create more complex things. That's why I didn't add a second one. You still think this is necessary?

@harshu1470
Copy link

Can I work on it?

@lambdaTotoro
Copy link
Collaborator

Sure, make a pull request and we'll have a look.

@harshu1470
Copy link

Thanks @lambdaTotoro

@harshu1470
Copy link

why I am getting login page directly instead of signup page after running jupyterhub?

@lambdaTotoro
Copy link
Collaborator

Defaulting to Login is a sensible thing to do, in my opinion, since logins are much, much more common than signups.

But please don't clog issues with unrelated questions.

@lambdaTotoro lambdaTotoro added this to the Version 1.1 milestone Oct 30, 2021
@lambdaTotoro
Copy link
Collaborator

I actually think this is good to have. The text @leportella refers to speaks about making it possible for users to see their password on login, but it would also be nice to have them confirm it on signup to root out typos in passwords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants