fix: we now need to await render_template method #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djangoliv
force-pushed
the
jupyterhub-1.3
branch
from
6ce8f7e
to
da214de
Compare
|
Do we know if this PR is compatible with older versions of the JupyterHub package? |
|
That does not seem the case. When I apply these changes it works with |
|
I can confirm this patch works great with jupyterhub-1.3.0. |
heroxbd
added a commit
to jiegec/gentoo-pypi-sci
that referenced
this pull request
Jan 9, 2021
Reference: jupyterhub/nativeauthenticator#129 Package-Manager: Portage-3.0.12, Repoman-3.0.1 Manifest-Sign-Key: 0xB9C8DC7BFA7F6667 Signed-off-by: Benda Xu <heroxbd@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without 'await' tornado raise a type Error (TypeError: write() only accepts bytes, unicode, and dict objects)
Regards