Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim package.json to avoid fields relevant to npm publication #212

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Sep 2, 2021

The version field isn't required unless we want to do npm publish which we don't. Most things in package.json can be removed actually, so I removed most things.

By removing repository and license, we got two warnings.

npm WARN nbgitpuller No repository field.
npm WARN nbgitpuller No license field.

I think this is fine, and that a slimmed package.json helps make this repo's code be more understandable. For reference, see the package.json docs.

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally

@manics manics merged commit 2fe5339 into jupyterhub:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants