Skip to content

Commit

Permalink
Remove userdata_method configuration supposedly not relevant
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio authored and minrk committed Mar 11, 2021
1 parent 545f5bb commit b0a59e4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
5 changes: 2 additions & 3 deletions docs/source/getting-started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ Set the above settings in your ``jupyterhub_config.py``:
c.GenericOAuthenticator.authorize_url = "https://your-AWSCognito-domain/oauth2/authorize"
c.GenericOAuthenticator.token_url = ""https://your-AWSCognito-domain/oauth2/token"
c.GenericOAuthenticator.userdata_url = "https://your-AWSCognito-domain/oauth2/userInfo"
c.GenericOAuthenticator.userdata_method = 'POST'
Azure AD Setup
--------------
Expand Down Expand Up @@ -463,11 +462,11 @@ Use the ``GenericOAuthenticator`` for Jupyterhub by editing your
c.GenericOAuthenticator.login_service = 'NAME-OF-SERVICE'
c.GenericOAuthenticator.userdata_url = 'http://YOUR-MOODLE-DOMAIN.com/local/oauth/user_info.php'
c.GenericOAuthenticator.token_url = 'http://YOUR-MOODLE-DOMAIN.com/local/oauth/token.php'
c.GenericOAuthenticator.userdata_method = 'POST'
c.GenericOAuthenticator.extra_params = {
'scope': 'user_info',
'client_id': 'MOODLE-CLIENT-ID',
'client_secret': 'MOODLE-CLIENT-SECRET-KEY'}
'client_secret': 'MOODLE-CLIENT-SECRET-KEY',
}
And set your environmental variable ``OAUTH2_AUTHORIZE_URL`` to:

Expand Down
7 changes: 0 additions & 7 deletions oauthenticator/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,6 @@ class GenericOAuthenticator(OAuthenticator):
help="Userdata params to get user data login information"
).tag(config=True)

userdata_method = Unicode(
os.environ.get('OAUTH2_USERDATA_METHOD', 'GET'),
config=True,
help="Userdata method to get user data login information",
)

userdata_token_method = Unicode(
os.environ.get('OAUTH2_USERDATA_REQUEST_TYPE', 'header'),
config=True,
Expand Down Expand Up @@ -133,7 +127,6 @@ def _get_user_data(self, token_response):

req = HTTPRequest(
url,
method=self.userdata_method,
headers=headers,
)
return self.fetch(req, "fetching user data")
Expand Down

0 comments on commit b0a59e4

Please sign in to comment.