Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Generic] Usage example for Nextcloud #268

Merged
merged 6 commits into from Jun 11, 2020
Merged

[Generic] Usage example for Nextcloud #268

merged 6 commits into from Jun 11, 2020

Conversation

arneki
Copy link

@arneki arneki commented Jun 1, 2019

No description provided.

@arneki
Copy link
Author

arneki commented Jun 1, 2019

Oh, I just realized that #263 also solves the problem with nested userdata, even including tests. I will adjust my pull request if this is merged first...

@consideRatio consideRatio changed the title GenericOAuthenticator: Allow nested keys in userdata and Nextcloud instructions in README [GenericOAuthenticator]: Allow nested keys in userdata and add Nextcloud instructions in README Nov 26, 2019
@consideRatio consideRatio changed the title [GenericOAuthenticator]: Allow nested keys in userdata and add Nextcloud instructions in README [GenericOAuthenticator] Allow nested keys in userdata and add Nextcloud instructions in README Nov 26, 2019
@consideRatio consideRatio changed the title [GenericOAuthenticator] Allow nested keys in userdata and add Nextcloud instructions in README [GenericOAuthenticator] Usage example for Nextcloud Nov 27, 2019
consideRatio
consideRatio requested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arneki for helping out with this! Sorry for the late response!

Oh, I just realized that #263 also solves the problem with nested userdata, even including tests. I will adjust my pull request if this is merged first...

The referenced PR wasn't merged, but #305 that accomplished the same thing (as I understand it) was! The documentation in this PR seem relevant still, could you strip away the other parts?

@arneki
Copy link
Author

arneki commented Nov 28, 2019

Thanks for the review!
Stripped out everything except of the documentation and adjusted it to the changes introduced in #305.

@minrk
Copy link
Member

minrk commented Jan 30, 2020

Sorry for leaving you hanging, @arneki, but can you re-issue this PR against the new docs which are now in docs/source/getting-started.rst? If not, I'm happy to translate the example to rst and add it.

@arneki arneki requested a review from consideRatio March 7, 2020 20:40
@minrk
Copy link
Member

minrk commented Jun 11, 2020

Thanks!

@minrk minrk merged commit 357a2af into jupyterhub:master Jun 11, 2020
@consideRatio consideRatio changed the title [GenericOAuthenticator] Usage example for Nextcloud [Generic] Usage example for Nextcloud Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio Awaiting requested review from consideRatio

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arneki @minrk @consideRatio