Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mixins, per-Authenticator LoginHandler classes #323

Merged
merged 19 commits into from
Jan 28, 2020
Merged

Remove mixins, per-Authenticator LoginHandler classes #323

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c0f3601
move authenticate_url, access_token_url to OAuthenticator base class
minrk Dec 18, 2019
443d39a
adopt mixin-less setup in github
minrk Dec 18, 2019
4e766dc
adopt mixin-less setup in gitlab
minrk Dec 18, 2019
b219f96
adopt mixin-less setup in google
minrk Dec 18, 2019
ac71230
adopt mixin-less setup in bitbucket
minrk Dec 18, 2019
1be7e50
adopt mixin-less in auth0
minrk Dec 18, 2019
982eaf1
promote generic userdata_url to base class
minrk Dec 18, 2019
b9cc59f
adopt mixin-less globus
minrk Dec 18, 2019
da14b4e
mixin-less in azure AD
minrk Dec 18, 2019
e85cb5b
mixin-less cilogon
minrk Dec 18, 2019
b468b2c
mixin-less okpy
minrk Dec 18, 2019
9d82497
mixin-less openshift
minrk Dec 18, 2019
6f62732
remove new-since-last-release providers
minrk Dec 18, 2019
4e27c50
replace docs referencing never-released authenticators with appropria…
minrk Dec 18, 2019
ee98e67
azuread b2c is the same as azuread with different config, no need for…
minrk Dec 18, 2019
b70742c
call it token_url
minrk Dec 18, 2019
b64f8d1
black config
minrk Dec 18, 2019
3b63294
make sure we actually use the new login handler class
minrk Dec 19, 2019
c601fee
consolidate base login_handler, callback_handler definitions
minrk Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion oauthenticator/oauth2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,11 @@ class OAuthenticator(Authenticator):
Subclasses must override:

login_service (string identifying the service provider)
login_handler (likely a subclass of OAuthLoginHandler)
authenticate (method takes one arg - the request handler handling the oauth callback)
"""

login_handler = OAuthLoginHandler

minrk marked this conversation as resolved.
Show resolved Hide resolved
authorize_url = Unicode(
config=True, help="""The authenticate url for initiating oauth"""
)
Expand Down