Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog for 0.11 #330

Merged
merged 2 commits into from
Jan 31, 2020
Merged

changelog for 0.11 #330

merged 2 commits into from
Jan 31, 2020

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 30, 2020

@manics
Copy link
Member

manics commented Jan 30, 2020

Are there any breaking changes in #323 that implementers of external Oauthenticator sub-classes need to be aware of?

consideRatio
consideRatio reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that we also removed the YandexPassportOAuthenticator that I merged =/

docs/source/changelog.md Outdated Show resolved Hide resolved
@minrk
Copy link
Member Author

minrk commented Jan 31, 2020

Are there any breaking changes in #323 that implementers of external OAuthenticator sub-classes need to be aware of?

There aren't any known, intentional breakages here. Subclasses should be fine. One exception, perhaps if any subclasses were importing the removed mixins.

@minrk
more changelog detail
2dbcf7d 
- note that removed mixins could have been imported by subclasses
- note that env-only config should be gone
@minrk
Copy link
Member Author

minrk commented Jan 31, 2020

I added a note about subclasses possibly importing the removed mixins and the fact that env-only config should be gone.

consideRatio
consideRatio approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, this LGTM! Merge and release?

@minrk
Copy link
Member Author

minrk commented Jan 31, 2020

@consideRatio I think so, yes!

@consideRatio consideRatio merged commit 1bf3274 into jupyterhub:master Jan 31, 2020
@consideRatio
Copy link
Member

I pushed a 0.11.0 git tag!

@minrk minrk deleted the changelog-0.11 branch January 31, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minrk @manics @consideRatio