[Generic] Fix failing GenericOAuthenticator tests #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still don't fully grasp this PR, but I learned enough to say it LGTM! I have never properly read up on Pytest mocking, and still haven't, but read enough to grasp what goes on with the patch() call thanks to this guide: https://realpython.com/python-mock-library/#patch |
consideRatio
approved these changes
Mar 9, 2020
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the
AsyncHTTPClientwithforce_instance=Trueattribute inGenericOAuthenticatormade the tests fail because the mocked http client was not being used anymore and instead an actualAsyncHttpClientinstance was being created and used (ref: https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py#L200).This PR forces the
GenericOAuthenticatortests use the mocked http client.