-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from travis to github actions #383
Conversation
683fa6b
to
c5a2f0c
Compare
731bcff
to
9aaac09
Compare
removes redundant circleci build as well, now that we use rtd on PRs
Results can be seen at https://github.com/minrk/oauthenticator/actions since we can't see action results on PRs until the first action PR is merged. This includes a generic action for publishing releases from tags that should work for ~any Python package. It always runs to make sure building releases isn't broken, but only publishes on tags |
fail-fast: false | ||
matrix: | ||
python: | ||
- "3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we are not testing py35 currently, but have not updated setup.py yet to require py36, so I figure this is fine to add but I think we should require py36 from now on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #384
LGTM! Thanks @minrk! |
also removes circle build of docs, since we have rtd set up for pull requests
closes #381