Add .fetch(req) method to base OAuthenticator
#415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consolidates: - httpclient instantiation - error logging - json deserialization reduces duplicate code across implementations
minrk
force-pushed
the
log-generic-errors
branch
from
c4615b8
to
d6b269b
Compare
minrk
commented
Mar 10, 2021
| @@ -39,128 +39,131 @@ def generic_client(client): | |||
| return client | |||
|
|
|||
|
|
|||
| async def test_generic(generic_client): | |||
There was a problem hiding this comment.
This diff is huge, but only because the http_client trait means the mock context is no longer necessary (it could always have been done with a fixture). These tests are just dedented with the context removed, in favor of the get_authenticator fixture.
|
|
||
| resp_json = json.loads(resp.body.decode('utf8', 'replace')) | ||
|
|
||
| resp_json = await self.fetch(req) |
There was a problem hiding this comment.
~all of the changes are this: replace two-line request & json.loads with single self.fetch, removing AsyncHTTPClient and the associated imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidates: