Support pyjwt >= 2 in tests #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the tests to be aware of the `pyjwt` version installed, converting the result of `jwt.encode()` from bytes to string and vice-versa accordingly as the return type changes between pyjwt versions.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
@rragundez as the author of #402 with relevant background knowledge, would you be willing to help out with a review on this PR? Thank you @diego-plan9 and @rragundez for your contributions! ❤️ 🎉 |
minrk
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the tests to be aware of the
pyjwtversion installed, converting the result ofjwt.encode()from bytes to string and vice-versa accordingly as the return type changes between pyjwt versions.Details
It seems that
pyjwtchanged the return type between major versions, and running the tests withpyjwt>=2.0seems to result in #432 (I have been able to replicate the same errors). Even ifmwoauthstill pins1.7.x(although might be able to use 2.x ) and as a result 2.x is never really installed in CI or a regular install, this PR tries to follow-up on the (guessed) rationale of #402 and #420 and allow running the test suite to support pyjwt 2.x.