Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/source/getting-started: mention openid scope for AzureAD + MFA #478

Merged

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Jan 9, 2022

  • Mention a hint from my own setup.
  • This would have saved me and other support staff hours of time, but
    I can't vouch for its absolute correctness. Still, it's only a
    hint...
  • Review: general check

- Mention a hint from my own setup.
- This would have saved me and other support staff hours of time, but
  I can't vouch for its absolute correctness.  Still, it's only a
  hint...
- Review: general check
@welcome
Copy link

welcome bot commented Jan 9, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@rkdarst
Copy link
Contributor Author

rkdarst commented Jan 9, 2022

pre-commit complained, but I can't see a useful error message (is it a pre-commit problem itself?) or how reorder-python-imports is related to this change...

@consideRatio
Copy link
Member

LGTM! Solved the pre-commit stuff in #479!

@consideRatio consideRatio merged commit d6fc04a into jupyterhub:master Jan 10, 2022
@welcome
Copy link

welcome bot commented Jan 10, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants