[CILogon] Don't make action a required field of CILogonOAuthenticator.allowed_idps follow-up #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
consideRatio
reviewed
Jun 9, 2022
consideRatio
reviewed
Jun 9, 2022
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
GeorgianaElena
changed the title
|
Thanks a lot @consideRatio! I believe I have addressed your comments. After the merge of this PR, I believe we should go for a 15.0.1 release. I also opened #518, but maybe that needs more discussion and should be released later? What do you think? |
|
@GeorgianaElena yepp unless its another bugfix, let's not include it before 15.0.1 is released. Want to go for a release? I merged a bigbucket bugfix pr just now as well btw. |
Yep! Let's see how it goes. I'll open up a PR with the updated changelog shortly |
|
I agree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #516. Without this, it's still impossible to don't specify an
action.This also adds a test and documents this option.
Ref: #514