Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and test refactoring #552

Closed
wants to merge 10 commits into from

Conversation

GeorgianaElena
Copy link
Member

Before #549, I believe some maintenance work needs to happen.
This PR:

  • moves repo_root/oauthenticator/tests to repo_root/tests (to be in line with other jupyterhub repos)
  • changes the .rst files to .md files and hopefully much of the old syntax with myst markdown one

Note

The docs content was not changed more than a few typos I spotted here and there, to not bloat this PR more.

@consideRatio
Copy link
Member

Wieee!!!! I appreciate that you do this chore work, as even reviewing markdown is preferable to me if additions are made later :)

Could you split apart this PR in two, where tests are relocated separately? I'm not feeling confident we can do that, but if we can and its okay, then I think its relevant to have in a dedicated PR to help highlight that in the changelog because its a possibly breaking change for people that relies on the tests, fixtures, or similar.

I'll come back and review the docs section as soon as I've completed the review on another PR!

Comment on lines +42 to +44
```{eval-rst}
.. literalinclude:: example-oauthenticator.py
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be written directly in MyST markup. I parse the rST code to be invoking a sphinx directive, and that would match in MyST markup as described here: https://myst-parser.readthedocs.io/en/latest/syntax/roles-and-directives.html

So it would become...

```{literalinclude} example-oauthenticator.py
```

Or perhaps this works?

```{literalinclude} example-oauthenticator.py```

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! The docs parts LGTM and is ready to merge following review comments resolves, but I'm cautious to merging the test folder relocation as part of this PR as it could even be a breaking change. I hope you feel alright with splitting this PR in two!

EDIT: I opened jupyterhub/team-compass#588 to get further input on the topic of relocating tests.

docs/source/install.md Outdated Show resolved Hide resolved
docs/source/install.md Outdated Show resolved Hide resolved
docs/source/install.md Outdated Show resolved Hide resolved
docs/source/getting-started.md Outdated Show resolved Hide resolved
GeorgianaElena and others added 5 commits November 25, 2022 16:52
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@GeorgianaElena
Copy link
Member Author

Haha, something strange happened. I've squashed the last commits, and I could see them squashed in the branch main...GeorgianaElena:oauthenticator:docs-refactoring, but not in this PR.

So I closed it, hoping to reopen it after and all to be fixed and updated. But now the reopen button is deactivated

@manics
Copy link
Member

manics commented Nov 26, 2022

If you force push to a branch and the PR is closed it'll be disconnected (I guess GitHub assumes a force push means you've reused the branch for something else?)

@GeorgianaElena
Copy link
Member Author

If you force push to a branch and the PR is closed it'll be disconnected

Very good thing to know 😅

I guess GitHub assumes a force push means you've reused the branch for something else?

Maybe 🤷🏼‍♀️ The other mystery thing is why the forced-pushed changes (commits squashing) didn't show up in the PR although everything seemed correct when checking out the actual branch.
I guess I manage to mess something up in between dropping, squashing and force-pushing commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants