[CILogonOAuthenticator] Add profile to default scope, fix detail following recent refactoring #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
reviewed
Mar 9, 2023
consideRatio
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Super happy that you find time to keep contributing to this work @GeorgianaElena!!!
- For the changelog, can you update to reflect that this is related to CILogon?
- For the PR label and PR description, I also wonder if this fixes a bug in the main branch and/or in a released version.
- Min has a practice of labelling fixed to unreleased versions to
maintenance, and I've labelled thembugormaintenancehistorically but start to think it makes more sense to go withmaintenance.
- Min has a practice of labelling fixed to unreleased versions to
6 tasks
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #551
I'm also adding "profile" to the list of default scopes. This scope is needed in order to be able to get the username when authenticating with GitHub. Otherwise, only the email would be available.
Note that
scopeis configurable and can always be modified per need.