Fix bug in implementation of not yet released basic_auth config #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the linked issue for details. I think this fixes a bug that would surface for someone trying to configure
basic_auth
directly (not via environment variables). If they would set it to True it would act as if it was set to False and the other way around.basic_auth
default value for all authenticators but generic #600We believe this fixes a bug introduced in a refactoring PR that hasn't yet been released.