maint: import Callable traitlet from jupyterhub #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/import-callable-traitlet
branch
from
076308b
to
0ef661f
Compare
manics
approved these changes
Apr 23, 2023
|
Maaaybe, leta mark it as breaking to be safe now that we make a major relase anyhow! |
|
I updated the PR description to include a Breaking change comment for the changelog for now. |
GeorgianaElena
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make use of a traitlet configuration type
Callablethat we imported by copy-paste to this project in #305 because we depended on jupyterhub>=0.5 at that time, and jupyterhub 0.5 didn't have the traitlet defined. This was discussed in #305 (review).Now we depend on
jupyterhub>=1.2, and the traitlet has been around and unchanged since then.Linkcheck failure
Breaking changes
oauthenticator.traitletsmodule with theCallableclass was removed but can now be imported fromjupyterhub.traitletsinstead.