Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORCID iD example configuration #657

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

matthewwiese
Copy link
Contributor

This PR resolves #284

It adds a subsection to the GenericOAuthenticator examples page for ORCID iDs.

Additionally, it adds a "note" to the top of the section on writing your own authenticator, in order to increase the visibility of the existing config examples.

Related: see #655 for more context

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manics manics merged commit 7937cd6 into jupyterhub:main Aug 10, 2023
3 checks passed
@welcome
Copy link

welcome bot commented Aug 10, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for ORCID-based authentication
2 participants