[Google] Fix regression in v16 of no longer stripping username's domain if hosted_domain has a single entry
#661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
changed the title
hosted_domain has a single entry
consideRatio
changed the title
hosted_domain has a single entryhosted_domain has a single entry
consideRatio
changed the title
hosted_domain has a single entryhosted_domain has a single entry
minrk
approved these changes
Aug 11, 2023
Co-authored-by: Min RK <benjaminrk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR influences users with GoogleOAuthenticator that had configured
hosted_domainwith a single domain entry.This PR is fixing a regression / undocumented breaking change introduced in oauthenticator 16.0.0 by returning things as they were before.