Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tljh-config error explicitly if called without sudo #5

Closed
yuvipanda opened this issue Sep 20, 2018 · 13 comments
Closed

Make tljh-config error explicitly if called without sudo #5

yuvipanda opened this issue Sep 20, 2018 · 13 comments
Labels
assigned This task is assigned to an applicant microtask Microtask for Outreachy applicants to complete during the contribution period

Comments

@yuvipanda
Copy link
Contributor

See jupyterhub/the-littlest-jupyterhub#120

@yuvipanda yuvipanda added project-nativeauth microtask Microtask for Outreachy applicants to complete during the contribution period labels Sep 20, 2018
@SansSeryph
Copy link

May I work on this task?

@yuvipanda
Copy link
Contributor Author

@kyle-harper yes! Consider it assigned :)

@yuvipanda
Copy link
Contributor Author

@kyla-harper gentle ping to see if you've made any progress :)

@SansSeryph
Copy link

@yuvipanda Not much, yet. Sorry about the delay, I've been caught up with my regular full time job and a few other life things. I do have time set aside to work on this today and the next few days though. :)

As a side note, I noticed that the installer script uses apt-get by default. I didn't see an issue opened for it yet but would it be okay for me to open a new issue to add options (or a set of checks) to use pacman and possibly yum? I never used yum before so I'm not sure if that would be appropriate to include it in the request just yet.

@yuvipanda
Copy link
Contributor Author

@kyla-harper no worries! take your time :)

Currently, we only support installation on Ubuntu 18.04+ systems. I think adding additional system support would be complicated, so I'd prefer to not do that just now.

https://the-littlest-jupyterhub.readthedocs.io/en/latest/contributing/dev-setup.html should help you get a dev env set up even if you do not have apt-get on your local system.

@SansSeryph
Copy link

Ah, okay. Thanks for the clarification and the link!

@minrk minrk added the assigned This task is assigned to an applicant label Oct 5, 2018
@anyushevai
Copy link

@yuvipanda , @kyla-harper hi!
Is this issue still being worked on? If not I would like to participate here.

@SansSeryph
Copy link

Hi @anyushevai, I'm finding that I have a lot less time to work on this than anticipated. I would say you should check in with @yuvipanda since he's the maintainer. I would be happy to remove myself from this task for someone else to work on this.

@minrk
Copy link
Member

minrk commented Oct 18, 2018

@kyla-harper thanks for making room. Feel free to check back in on another task if you feel you have the time.

@minrk
Copy link
Member

minrk commented Oct 18, 2018

@anyushevai consider this task assigned to you

@minrk
Copy link
Member

minrk commented Oct 25, 2018

Great job, @anyushevai!

@anyushevai
Copy link

@minrk Thank you!

@choldgraf
Copy link
Member

wooo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned This task is assigned to an applicant microtask Microtask for Outreachy applicants to complete during the contribution period
Projects
None yet
Development

No branches or pull requests

5 participants