add warning if tljh-config is called as non-root user #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Oct 22, 2018
tljh/config.py
Outdated
| reload_component(args.component) | ||
| else: | ||
| argparser.print_help() | ||
| except Exception as e: |
There was a problem hiding this comment.
Rather than catching all errors here, let's try proactively checking if os.geteuid() != 0, which is the condition when it is run as a non-root user. Maybe show an early warning in this case, indicating that it may fail with permission errors?
choldgraf
reviewed
Oct 24, 2018
Co-Authored-By: anyushevai <irina.anyusheva@gmail.com>
minrk
reviewed
Oct 24, 2018
Co-Authored-By: anyushevai <irina.anyusheva@gmail.com>
|
This LGTM! If @minrk is +1 on the way to check for root then I'm +1 on merge! Thanks @anyushevai 🎉 |
minrk
changed the title
|
Thanks, @anyushevai! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be two separate errors that occurred if we run the command without sudo:
[Errno 13] Permission denied: '/opt/tljh/installer.log'
at line 226
And
[Errno 13] Permission denied: '/opt/tljh/config/config.yaml'
at lines 294-305
Now we print an error and print a message about using 'sudo -E'.
I thought about putting the whole main function into one try-except block, but it seems more appropriate to use two different try-except blocks.
jupyterhub/outreachy#5
closes #120