-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 support to repo2docker #1180
Conversation
.github/workflows/test.yml
Outdated
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v2 | ||
with: | ||
platforms: 'arm64,arm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running all the tests under qemu is going to take a long time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: in z2jh we do the following, where --platform
is passed during docker build
is run by chartpress.
@yuvipanda I think you should only specify arm64 and not arm64,arm - at least unless you wish to go for arm32 support as well. Typically, the support for arm64 is quite more common, and in z2jh for example we provide arm64 + amd64 but not arm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@consideRatio yay ty. Just switched it to arm64.
@minrk I'm trying to get it to at least run on arm64 now, and can't get it to run at all :( I think it's still just running on amd64 despite me passing platform, not sure why.
I'm guessing this should be commandline param passed in. |
I see:
everywhere, and am not sure if qemu is actually even being used? We don't use buildx, as we talk to it via the docker API (not |
Looks like docker-py doesn't support buildx docker/docker-py#2230 |
If the build steps don't fail immediately, qemu's involved. You'll get some kind of |
@minrk they currently fail with:
which I'd assume means they aren't using QEMU, and that's the arm binary trying to get started in an amd64 context. It works on my local machine tho |
Given how long our tests take, it may make sense to run arm tests on circle. I just did this on pyzmq, and it was ~10x faster than qemu on GHA. Presumably we only need a pretty basic couple of tests, though. |
I dunno when I'll be able to work on this again though, would love for someone else to take it over <3 |
This is a PR related to #1055 |
A tarot card reader on the streets of los angeles told me that completion of this PR is not something she sees in my future given that Saturn is in retrograde, and I will hence close this in favor of the amazing #1228 |
I got a M1 Mac, what else does one do to procrastinate?
Fixes #1120
TODO: