Remove deprecated nteract_on_jupyter #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
betatim
approved these changes
Apr 3, 2023
|
The failing test is passing on |
consideRatio
force-pushed
the
nomointeract
branch
from
588b6f8
to
23f8f54
Compare
Last release was in 2019, and it has been explicilty deprecated for a while nteract/nteract#5554 (comment) TLJH plans to remove it in jupyterhub/the-littlest-jupyterhub#869
consideRatio
force-pushed
the
nomointeract
branch
from
23f8f54
to
f87c86c
Compare
|
I wanted to help this get merged so I did the following:
The readthedocs build failure is unrelated, showing up in the main branch as well: |
|
Amazing, ty @consideRatio! This LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last release was in 2019, and it has been explicilty deprecated for a while
nteract/nteract#5554 (comment)
Was removed in TLJH in jupyterhub/the-littlest-jupyterhub#842 (EDIT: in jupyterhub/the-littlest-jupyterhub#869)