Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying images to reuse cache from #478

Merged
merged 9 commits into from Dec 11, 2018
Merged

Allow specifying images to reuse cache from #478

merged 9 commits into from Dec 11, 2018

Commits on Dec 5, 2018

  1. Allow specifying images to reuse cache from 

    This lets us explicitly specify images that repo2docker
should try to re-use cached layers from. Docker normally only
looks for layers from images that were *built* locally - if
we want it to look in images that were *pulled* from a registry,
we need to specify it here.
    @yuvipanda
    yuvipanda committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1dacdd4 View commit details
    Browse the repository at this point in the history

  2. Add traitlet for reuse_layers_from 

    More accurate name in our context
    @yuvipanda
    yuvipanda committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    f5ced79 View commit details
    Browse the repository at this point in the history

  3. Pass through cache_from to legacy buildpack too

    @yuvipanda
    yuvipanda committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    569e6cf View commit details
    Browse the repository at this point in the history

  4. Use --cache-from as arg name to match docker build

    @yuvipanda
    yuvipanda committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    89665ea View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Merge branch 'master' into cache-from 

    Merges in this revert: jupyterhub#481
    @yuvipanda
    yuvipanda committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3b515aa View commit details
    Browse the repository at this point in the history

  2. Inject docker.APIClient into methods that need them 

    - Creating a new client with 'auto' version causes repeated
  unnecessary network requests to discover version of docker daemon.
- Testing is easier this way, since we can inject a mocked docker
  client more easily
    @yuvipanda
    yuvipanda committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3b0b772 View commit details
    Browse the repository at this point in the history

  3. Add tests for cache_from functionality

    @yuvipanda
    yuvipanda committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    47335f4 View commit details
    Browse the repository at this point in the history

  4. Pass cache_from through to build 

    Got lost in a merge
    @yuvipanda
    yuvipanda committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    b4dbc98 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Add tests for Docker & Legacy Docker buildpacks

    @yuvipanda
    yuvipanda committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    d035483 View commit details
    Browse the repository at this point in the history