Replace deprecated MemoryLimit with MemoryMax, remove fixme notes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemoryMax replaces MemoryLimit and has been introduced at least in v243 already.
behrmann
reviewed
Jun 1, 2023
Co-authored-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>
|
Thanks a lot, @consideRatio! And thanks for the review, @behrmann! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126 where I did an investigation related to the removed fixme notes.
This change should not be breaking because MemoryMax replaces MemoryLimit according to docs, and has been documented to do that since v243 at least. See #126 for investigative notes about that.