Skip to content

Commit

Permalink
Merge pull request #591 from yuvipanda/bump/lab
Browse files Browse the repository at this point in the history
Upgrade JupyterLab version
  • Loading branch information
GeorgianaElena committed Jul 28, 2020
2 parents 462b01c + 6db016f commit e8136c0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
11 changes: 1 addition & 10 deletions integration-tests/test_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def test_serverextensions():
], stderr=subprocess.PIPE)

extensions = [
'jupyterlab 1.2.',
'jupyterlab 2.',
'nbgitpuller 0.7.',
'nteract_on_jupyter 2.1.',
'nbresuse '
Expand Down Expand Up @@ -43,12 +43,3 @@ def test_nbextensions():

# Ensure we have 'OK' messages in our stdout, to make sure everything is importable
assert proc.stderr.decode() == ' - Validating: \x1b[32mOK\x1b[0m\n' * len(extensions)


def test_labextensions():
"""
Validate labextensions we want installed
"""
# Currently we only install jupyterhub
assert os.path.exists('/opt/tljh/user/bin/jupyter-labhub')

4 changes: 3 additions & 1 deletion tljh/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ def ensure_jupyterlab_extensions():
Install the JupyterLab extensions we want.
"""
extensions = [
'@jupyter-widgets/jupyterlab-manager@1.1' # for jupyterlab 1.2.x
# We don't pin versions here, since labextension will find something
# appropriate for our version of jupyterlab
'@jupyter-widgets/jupyterlab-manager'
]
install_options = [
'--no-build' # do not build extension at install time. Will build later
Expand Down
2 changes: 1 addition & 1 deletion tljh/requirements-base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
jupyterhub==1.0.*
notebook==6.0.*
# Install additional notebook frontends!
jupyterlab==1.2.*
jupyterlab==2.*
nteract-on-jupyter==2.1.*
# nbgitpuller for easily pulling in Git repositories
nbgitpuller==0.7.*
Expand Down

0 comments on commit e8136c0

Please sign in to comment.